Compare a given version number in the form major.minor.build.patch and see if one is less than the other Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number

What's the purpose of writing one's academic biography in the third person?

Single word antonym of "flightless"

How does the particle を relate to the verb 行く in the structure「A を + B に行く」?

Do I really need recursive chmod to restrict access to a folder?

Why is "Consequences inflicted." not a sentence?

What does this icon in iOS Stardew Valley mean?

Dating a Former Employee

Generate an RGB colour grid

How to deal with a team lead who never gives me credit?

How do I keep my slimes from escaping their pens?

String `!23` is replaced with `docker` in command line

Can an alien society believe that their star system is the universe?

How discoverable are IPv6 addresses and AAAA names by potential attackers?

Is it ethical to give a final exam after the professor has quit before teaching the remaining chapters of the course?

What exactly is a "Meth" in Altered Carbon?

Gordon Ramsay Pudding Recipe

How to find all the available tools in mac terminal?

What does an IRS interview request entail when called in to verify expenses for a sole proprietor small business?

If a contract sometimes uses the wrong name, is it still valid?

Why do we bend a book to keep it straight?

3 doors, three guards, one stone

Why didn't this character "real die" when they blew their stack out in Altered Carbon?

When a candle burns, why does the top of wick glow if bottom of flame is hottest?

Why do people hide their license plates in the EU?



Compare a given version number in the form major.minor.build.patch and see if one is less than the other



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








2












$begingroup$


#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdbool.h>

typedef int STATUS;
#define ERROR -1
#define OKAY 0

struct version

unsigned char major;
unsigned char minor;
unsigned char build;
unsigned char patch;
;
STATUS is_less_than(struct version * original, struct version *compared, bool *result)
compared == NULL


Is there a cleaner way to do this?










share|improve this question









$endgroup$


















    2












    $begingroup$


    #include <stdio.h>
    #include <stdlib.h>
    #include <string.h>
    #include <stdbool.h>

    typedef int STATUS;
    #define ERROR -1
    #define OKAY 0

    struct version

    unsigned char major;
    unsigned char minor;
    unsigned char build;
    unsigned char patch;
    ;
    STATUS is_less_than(struct version * original, struct version *compared, bool *result)
    compared == NULL


    Is there a cleaner way to do this?










    share|improve this question









    $endgroup$














      2












      2








      2





      $begingroup$


      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)
      compared == NULL


      Is there a cleaner way to do this?










      share|improve this question









      $endgroup$




      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)
      compared == NULL


      Is there a cleaner way to do this?







      c






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 5 hours ago









      the_endianthe_endian

      396212




      396212




















          3 Answers
          3






          active

          oldest

          votes


















          2












          $begingroup$

          Yes, there is a cleaner way:



          if (a.major != b.major) 
          *result = a.major < b.major;
          else if (a.minor != b.minor)
          *result = a.minor < b.minor;
          else if (a.patch != b.patch)
          *result = a.patch < b.patch;
          else
          *result = a.build < b.build;

          return OKAY;


          I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



          Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






          share|improve this answer











          $endgroup$












          • $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            1 hour ago


















          0












          $begingroup$

          Return status



          You create this:



          typedef int STATUS;
          #define ERROR -1
          #define OKAY 0


          which is basically a boolean status. Personally, I'd return a straight bool.



          Bug/Not what you mean



          Doing a



          result = NULL;


          is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



          Shorter version



          I'm not sure this is cleaner, but here I go:



          bool is_less_than(struct version * original, struct version *compared, bool *result)



          Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



          int main(void) 

          struct version ref = 1, 2, 21, 8 ;
          struct version lower1 = 0, 2, 21, 8 ;
          struct version lower2 = 1, 1, 21, 8 ;
          struct version lower3 = 1, 2, 20, 8 ;
          struct version lower4 = 1, 2, 21, 7 ;
          struct version equal = 1, 2, 21, 8 ;
          struct version higher1 = 2, 2, 21, 8 ;
          struct version higher2 = 1, 3, 21, 8 ;
          struct version higher3 = 1, 2, 22, 8 ;
          struct version higher4 = 1, 2, 21, 9 ;

          #define TEST(a,b,expect1,expect2)
          do
          bool result1, result2;
          is_less_than((a), (b), &result1);
          is_less_than((b), (a), &result2);
          puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
          while(0)
          #define TESTL(a,b) TEST(a,b,true,false)
          #define TESTE(a,b) TEST(a,b,false,false)
          #define TESTH(a,b) TEST(a,b,false,true)

          TESTL(&lower1, &ref);
          TESTL(&lower2, &ref);
          TESTL(&lower3, &ref);
          TESTL(&lower4, &ref);
          TESTE(&equal, &ref);
          TESTH(&higher1, &ref);
          TESTH(&higher2, &ref);
          TESTH(&higher3, &ref);
          TESTH(&higher4, &ref);

          return 0;






          share|improve this answer











          $endgroup$








          • 1




            $begingroup$
            As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
            $endgroup$
            – Roland Illig
            1 hour ago











          • $begingroup$
            @RolandIllig Updated. Thank you for the suggestion.
            $endgroup$
            – Costantino Grana
            1 hour ago


















          0












          $begingroup$

          I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



          The danger is further complicated by the fact that neither of the in-parameters is declared const.



          Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



          With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



          bool is_less_than(struct version a, struct version b) 
          return a.major != b.major ? a.major < b.major :
          a.minor != b.minor ? a.minor < b.minor :
          a.patch != b.patch ? a.patch < b.patch :
          a.build < b.build;



          I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






          share|improve this answer









          $endgroup$













            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            3 Answers
            3






            active

            oldest

            votes








            3 Answers
            3






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            2












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              1 hour ago















            2












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              1 hour ago













            2












            2








            2





            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$



            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.







            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited 1 hour ago

























            answered 1 hour ago









            Roland IlligRoland Illig

            11.6k11946




            11.6k11946











            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              1 hour ago
















            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              1 hour ago















            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            1 hour ago




            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            1 hour ago













            0












            $begingroup$

            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)



            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              1 hour ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago















            0












            $begingroup$

            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)



            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              1 hour ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago













            0












            0








            0





            $begingroup$

            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)



            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;






            share|improve this answer











            $endgroup$



            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)



            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;







            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited 1 hour ago

























            answered 1 hour ago









            Costantino GranaCostantino Grana

            18728




            18728







            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              1 hour ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago












            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              1 hour ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago







            1




            1




            $begingroup$
            As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
            $endgroup$
            – Roland Illig
            1 hour ago





            $begingroup$
            As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
            $endgroup$
            – Roland Illig
            1 hour ago













            $begingroup$
            @RolandIllig Updated. Thank you for the suggestion.
            $endgroup$
            – Costantino Grana
            1 hour ago




            $begingroup$
            @RolandIllig Updated. Thank you for the suggestion.
            $endgroup$
            – Costantino Grana
            1 hour ago











            0












            $begingroup$

            I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



            The danger is further complicated by the fact that neither of the in-parameters is declared const.



            Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



            With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



            bool is_less_than(struct version a, struct version b) 
            return a.major != b.major ? a.major < b.major :
            a.minor != b.minor ? a.minor < b.minor :
            a.patch != b.patch ? a.patch < b.patch :
            a.build < b.build;



            I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






            share|improve this answer









            $endgroup$

















              0












              $begingroup$

              I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



              The danger is further complicated by the fact that neither of the in-parameters is declared const.



              Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



              With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



              bool is_less_than(struct version a, struct version b) 
              return a.major != b.major ? a.major < b.major :
              a.minor != b.minor ? a.minor < b.minor :
              a.patch != b.patch ? a.patch < b.patch :
              a.build < b.build;



              I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






              share|improve this answer









              $endgroup$















                0












                0








                0





                $begingroup$

                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






                share|improve this answer









                $endgroup$



                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 45 mins ago









                200_success200_success

                131k17157422




                131k17157422



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Францішак Багушэвіч Змест Сям'я | Біяграфія | Творчасць | Мова Багушэвіча | Ацэнкі дзейнасці | Цікавыя факты | Спадчына | Выбраная бібліяграфія | Ушанаванне памяці | У філатэліі | Зноскі | Літаратура | Спасылкі | НавігацыяЛяхоўскі У. Рупіўся дзеля Бога і людзей: Жыццёвы шлях Лявона Вітан-Дубейкаўскага // Вольскі і Памідораў з песняй пра немца Адвакат, паэт, народны заступнік Ашмянскі веснікВ Минске появится площадь Богушевича и улица Сырокомли, Белорусская деловая газета, 19 июля 2001 г.Айцец беларускай нацыянальнай ідэі паўстаў у бронзе Сяргей Аляксандравіч Адашкевіч (1918, Мінск). 80-я гады. Бюст «Францішак Багушэвіч».Яўген Мікалаевіч Ціхановіч. «Партрэт Францішка Багушэвіча»Мікола Мікалаевіч Купава. «Партрэт зачынальніка новай беларускай літаратуры Францішка Багушэвіча»Уладзімір Іванавіч Мелехаў. На помніку «Змагарам за родную мову» Барэльеф «Францішак Багушэвіч»Памяць пра Багушэвіча на Віленшчыне Страчаная сталіца. Беларускія шыльды на вуліцах Вільні«Krynica». Ideologia i przywódcy białoruskiego katolicyzmuФранцішак БагушэвічТворы на knihi.comТворы Францішка Багушэвіча на bellib.byСодаль Уладзімір. Францішак Багушэвіч на Лідчыне;Луцкевіч Антон. Жыцьцё і творчасьць Фр. Багушэвіча ў успамінах ягоных сучасьнікаў // Запісы Беларускага Навуковага таварыства. Вільня, 1938. Сшытак 1. С. 16-34.Большая российская1188761710000 0000 5537 633Xn9209310021619551927869394п

                    Беларусь Змест Назва Гісторыя Геаграфія Сімволіка Дзяржаўны лад Палітычныя партыі Міжнароднае становішча і знешняя палітыка Адміністрацыйны падзел Насельніцтва Эканоміка Культура і грамадства Сацыяльная сфера Узброеныя сілы Заўвагі Літаратура Спасылкі НавігацыяHGЯOiТоп-2011 г. (па версіі ej.by)Топ-2013 г. (па версіі ej.by)Топ-2016 г. (па версіі ej.by)Топ-2017 г. (па версіі ej.by)Нацыянальны статыстычны камітэт Рэспублікі БеларусьШчыльнасць насельніцтва па краінахhttp://naviny.by/rubrics/society/2011/09/16/ic_articles_116_175144/А. Калечыц, У. Ксяндзоў. Спробы засялення краю неандэртальскім чалавекам.І ў Менску былі мамантыА. Калечыц, У. Ксяндзоў. Старажытны каменны век (палеаліт). Першапачатковае засяленне тэрыторыіГ. Штыхаў. Балты і славяне ў VI—VIII стст.М. Клімаў. Полацкае княства ў IX—XI стст.Г. Штыхаў, В. Ляўко. Палітычная гісторыя Полацкай зямліГ. Штыхаў. Дзяржаўны лад у землях-княствахГ. Штыхаў. Дзяржаўны лад у землях-княствахБеларускія землі ў складзе Вялікага Княства ЛітоўскагаЛюблінская унія 1569 г."The Early Stages of Independence"Zapomniane prawdy25 гадоў таму было аб'яўлена, што Язэп Пілсудскі — беларус (фота)Наша вадаДакументы ЧАЭС: Забруджванне тэрыторыі Беларусі « ЧАЭС Зона адчужэнняСведения о политических партиях, зарегистрированных в Республике Беларусь // Министерство юстиции Республики БеларусьСтатыстычны бюлетэнь „Полаўзроставая структура насельніцтва Рэспублікі Беларусь на 1 студзеня 2012 года і сярэднегадовая колькасць насельніцтва за 2011 год“Индекс человеческого развития Беларуси — не было бы нижеБеларусь занимает первое место в СНГ по индексу развития с учетом гендерного факцёраНацыянальны статыстычны камітэт Рэспублікі БеларусьКанстытуцыя РБ. Артыкул 17Трансфармацыйныя задачы БеларусіВыйсце з крызісу — далейшае рэфармаванне Беларускі рубель — сусветны лідар па дэвальвацыяхПра змену коштаў у кастрычніку 2011 г.Бядней за беларусаў у СНД толькі таджыкіСярэдні заробак у верасні дасягнуў 2,26 мільёна рублёўЭканомікаГаласуем за ТОП-100 беларускай прозыСучасныя беларускія мастакіАрхитектура Беларуси BELARUS.BYА. Каханоўскі. Культура Беларусі ўсярэдзіне XVII—XVIII ст.Анталогія беларускай народнай песні, гуказапісы спеваўБеларускія Музычныя IнструментыБеларускі рок, які мы страцілі. Топ-10 гуртоў«Мясцовы час» — нязгаслая легенда беларускай рок-музыкіСЯРГЕЙ БУДКІН. МЫ НЯ ЗНАЕМ СВАЁЙ МУЗЫКІМ. А. Каладзінскі. НАРОДНЫ ТЭАТРМагнацкія культурныя цэнтрыПублічная дыскусія «Беларуская новая пьеса: без беларускай мовы ці беларуская?»Беларускія драматургі па-ранейшаму лепш ставяцца за мяжой, чым на радзіме«Працэс незалежнага кіно пайшоў, і дзяржаву турбуе яго непадкантрольнасць»Беларускія філосафы ў пошуках прасторыВсе идём в библиотекуАрхіваванаАб Нацыянальнай праграме даследавання і выкарыстання касмічнай прасторы ў мірных мэтах на 2008—2012 гадыУ космас — разам.У суседнім з Барысаўскім раёне пабудуюць Камандна-вымяральны пунктСвяты і абрады беларусаў«Мірныя бульбашы з малой краіны» — 5 непраўдзівых стэрэатыпаў пра БеларусьМ. Раманюк. Беларускае народнае адзеннеУ Беларусі скарачаецца колькасць злачынстваўЛукашэнка незадаволены мінскімі ўладамі Крадзяжы складаюць у Мінску каля 70% злачынстваў Узровень злачыннасці ў Мінскай вобласці — адзін з самых высокіх у краіне Генпракуратура аналізуе стан са злачыннасцю ў Беларусі па каэфіцыенце злачыннасці У Беларусі стабілізавалася крымінагеннае становішча, лічыць генпракурорЗамежнікі сталі здзяйсняць у Беларусі больш злачынстваўМУС Беларусі турбуе рост рэцыдыўнай злачыннасціЯ з ЖЭСа. Дазволіце вас абкрасці! Рэйтынг усіх службаў і падраздзяленняў ГУУС Мінгарвыканкама вырасАб КДБ РБГісторыя Аператыўна-аналітычнага цэнтра РБГісторыя ДКФРТаможняagentura.ruБеларусьBelarus.by — Афіцыйны сайт Рэспублікі БеларусьСайт урада БеларусіRadzima.org — Збор архітэктурных помнікаў, гісторыя Беларусі«Глобус Беларуси»Гербы и флаги БеларусиАсаблівасці каменнага веку на БеларусіА. Калечыц, У. Ксяндзоў. Старажытны каменны век (палеаліт). Першапачатковае засяленне тэрыторыіУ. Ксяндзоў. Сярэдні каменны век (мезаліт). Засяленне краю плямёнамі паляўнічых, рыбакоў і збіральнікаўА. Калечыц, М. Чарняўскі. Плямёны на тэрыторыі Беларусі ў новым каменным веку (неаліце)А. Калечыц, У. Ксяндзоў, М. Чарняўскі. Гаспадарчыя заняткі ў каменным векуЭ. Зайкоўскі. Духоўная культура ў каменным векуАсаблівасці бронзавага веку на БеларусіФарміраванне супольнасцей ранняга перыяду бронзавага векуФотографии БеларусиРоля беларускіх зямель ва ўтварэнні і ўмацаванні ВКЛВ. Фадзеева. З гісторыі развіцця беларускай народнай вышыўкіDMOZGran catalanaБольшая российскаяBritannica (анлайн)Швейцарскі гістарычны15325917611952699xDA123282154079143-90000 0001 2171 2080n9112870100577502ge128882171858027501086026362074122714179пппппп

                    ValueError: Expected n_neighbors <= n_samples, but n_samples = 1, n_neighbors = 6 (SMOTE) The 2019 Stack Overflow Developer Survey Results Are InCan SMOTE be applied over sequence of words (sentences)?ValueError when doing validation with random forestsSMOTE and multi class oversamplingLogic behind SMOTE-NC?ValueError: Error when checking target: expected dense_1 to have shape (7,) but got array with shape (1,)SmoteBoost: Should SMOTE be ran individually for each iteration/tree in the boosting?solving multi-class imbalance classification using smote and OSSUsing SMOTE for Synthetic Data generation to improve performance on unbalanced dataproblem of entry format for a simple model in KerasSVM SMOTE fit_resample() function runs forever with no result