Yu-Gi-Oh cards in Python 3 The Next CEO of Stack OverflowGenerating playing cardsASCII-fication of playing cardsFunction for shuffling cardsDynamic class instancing (with conditional parameters and methods) based on a dictionaryMy first finished Python program: a deck of cardsDeck of cards designMaking a deck of cards in PythonPoker Hand classifer part 3: Deck Object and 7 Card HandSimple Deck of Cards Python ProgramDeal three Poker hands of five cards each in Python

Can you be charged for obstruction for refusing to answer questions?

Yu-Gi-Oh cards in Python 3

How to write a definition with variants?

Make solar eclipses exceedingly rare, but still have new moons

How to avoid supervisors with prejudiced views?

Won the lottery - how do I keep the money?

Is it convenient to ask the journal's editor for two additional days to complete a review?

If Nick Fury and Coulson already knew about aliens (Kree and Skrull) why did they wait until Thor's appearance to start making weapons?

A small doubt about the dominated convergence theorem

Flying from Cape Town to England and return to another province

Why did CATV standarize in 75 ohms and everyone else in 50?

Why, when going from special to general relativity, do we just replace partial derivatives with covariant derivatives?

Solving system of ODEs with extra parameter

Can we say or write : "No, it'sn't"?

RigExpert AA-35 - Interpreting The Information

How many extra stops do monopods offer for tele photographs?

When you upcast Blindness/Deafness, do all targets suffer the same effect?

Math-accent symbol over parentheses enclosing accented symbol (amsmath)

How to invert MapIndexed on a ragged structure? How to construct a tree from rules?

Is it ever safe to open a suspicious HTML file (e.g. email attachment)?

Should I tutor a student who I know has cheated on their homework?

The past simple of "gaslight" – "gaslighted" or "gaslit"?

Does soap repel water?

How to edit “Name” property in GCI output?



Yu-Gi-Oh cards in Python 3



The Next CEO of Stack OverflowGenerating playing cardsASCII-fication of playing cardsFunction for shuffling cardsDynamic class instancing (with conditional parameters and methods) based on a dictionaryMy first finished Python program: a deck of cardsDeck of cards designMaking a deck of cards in PythonPoker Hand classifer part 3: Deck Object and 7 Card HandSimple Deck of Cards Python ProgramDeal three Poker hands of five cards each in Python










4












$begingroup$


I made a project in Python 3.7.1 that includes classes to create Yu-Gi-Oh cards. This isn't the entire game; it is just the cards itself. I will create the entire game later. I want feedback on how to improve my code.



class Deck(object):
def __init__(self, main_deck):
self.main_deck = main_deck

def add_normal_cards(self, card_to_add, all_cards):
"""
Add monsters, spells and traps to the deck.
"""
if len(self.main_deck) > 60:
return "You have to many cards in your deck (60)."
else:
card_counter = 0
# Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
# will be added eventually.
for card in self.main_deck:
if card == card_to_add:
card_counter += 1
if card_counter == 3:
return "You have to many copies of that card in your deck (3)."
else:
if card_to_add not in all_cards:
return "That card hasn't been added to the game yet (" + card_to_add + ")."
else:
self.main_deck.append(card_to_add)

def add_extra_cards(self, card_to_add, all_cards):
"""
Add monsters, spells and traps to the deck.
"""
if len(self.main_deck) > 15:
return "You have to many cards in your extra deck (15)."
else:
card_counter = 0
# Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
# will be added eventually.
for card in self.main_deck:
if card == card_to_add:
card_counter += 1
if card_counter == 3:
return "You have to many copies of that card in your deck (3)."
else:
if card_to_add not in all_cards:
return "That card hasn't been added to the game yet (" + card_to_add + ")."
else:
self.main_deck.append(card_to_add)


class Monster(object):
def __init__(self, name, effects, attributes, monster_type, atk, _def, description):
self.name = name
self.effects = effects
self.attributes = attributes
self.type = monster_type
self.atk = atk
self._def = _def
self.description = description

def effect(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)


class Spell(object):
def __init__(self, name, effects):
self.name = name
self.effects = effects

def activate(self):
"""
Activate the effect of this spell.
"""
for effect in self.effects:
eval(effect)


class Trap(object):
def __init__(self, name, effects):
self.name = name
self.effects = effects

def activate(self):
"""
Activate the effect of this spell.
"""
for effect in self.effects:
eval(effect)


class LinkMonster(object):
def __init__(self, name, effects, attributes, monster_type, atk, link_rating, description, recipe, links):
self.name = name
self.effects = effects
self.attributes = attributes
self.type = monster_type
self.atk = atk
self.link_rating = link_rating
self.description = description
self.recipe = recipe
self.links = links

def activate(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)


class SynchroMonster(object):
def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
self.name = name
self.effects = effects
self.attributes = attributes
self.type = monster_type
self.atk = atk
self._def = _def
self.description = description
self.recipe = recipe

def activate(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)


class XyzMonster(object):
def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
self.name = name
self.effects = effects
self.attributes = attributes
self.type = monster_type
self.atk = atk
self._def = _def
self.description = description
self.recipe = recipe
self.materials = recipe

def activate(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)


class FusionMonster(object):
def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
self.name = name
self.effects = effects
self.attributes = attributes
self.type = monster_type
self.atk = atk
self._def = _def
self.description = description
self.recipe = recipe

def activate(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)


class PendulumMonster(object):
def __init__(self, name, effects, pendulum_effects, pendulum_scale, attributes, monster_type, atk, _def,
description, recipe):
self.name = name
self.effects = effects
self.pendulum_effects = pendulum_effects
self.pendulum_scale = pendulum_scale
self.attributes = attributes
self.type = monster_type
self.atk = atk
self._def = _def
self.description = description
self.recipe = recipe
self.materials = recipe

def activate(self):
"""
Activate the effect of this monster.
"""
for effect in self.effects:
eval(effect)

def pendulum_activate(self):
"""
Activate the effect of this monster while in Spell/Trap Zone.
"""
for effect in self.pendulum_effects:
eval(effect)









share|improve this question











$endgroup$
















    4












    $begingroup$


    I made a project in Python 3.7.1 that includes classes to create Yu-Gi-Oh cards. This isn't the entire game; it is just the cards itself. I will create the entire game later. I want feedback on how to improve my code.



    class Deck(object):
    def __init__(self, main_deck):
    self.main_deck = main_deck

    def add_normal_cards(self, card_to_add, all_cards):
    """
    Add monsters, spells and traps to the deck.
    """
    if len(self.main_deck) > 60:
    return "You have to many cards in your deck (60)."
    else:
    card_counter = 0
    # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
    # will be added eventually.
    for card in self.main_deck:
    if card == card_to_add:
    card_counter += 1
    if card_counter == 3:
    return "You have to many copies of that card in your deck (3)."
    else:
    if card_to_add not in all_cards:
    return "That card hasn't been added to the game yet (" + card_to_add + ")."
    else:
    self.main_deck.append(card_to_add)

    def add_extra_cards(self, card_to_add, all_cards):
    """
    Add monsters, spells and traps to the deck.
    """
    if len(self.main_deck) > 15:
    return "You have to many cards in your extra deck (15)."
    else:
    card_counter = 0
    # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
    # will be added eventually.
    for card in self.main_deck:
    if card == card_to_add:
    card_counter += 1
    if card_counter == 3:
    return "You have to many copies of that card in your deck (3)."
    else:
    if card_to_add not in all_cards:
    return "That card hasn't been added to the game yet (" + card_to_add + ")."
    else:
    self.main_deck.append(card_to_add)


    class Monster(object):
    def __init__(self, name, effects, attributes, monster_type, atk, _def, description):
    self.name = name
    self.effects = effects
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self._def = _def
    self.description = description

    def effect(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)


    class Spell(object):
    def __init__(self, name, effects):
    self.name = name
    self.effects = effects

    def activate(self):
    """
    Activate the effect of this spell.
    """
    for effect in self.effects:
    eval(effect)


    class Trap(object):
    def __init__(self, name, effects):
    self.name = name
    self.effects = effects

    def activate(self):
    """
    Activate the effect of this spell.
    """
    for effect in self.effects:
    eval(effect)


    class LinkMonster(object):
    def __init__(self, name, effects, attributes, monster_type, atk, link_rating, description, recipe, links):
    self.name = name
    self.effects = effects
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self.link_rating = link_rating
    self.description = description
    self.recipe = recipe
    self.links = links

    def activate(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)


    class SynchroMonster(object):
    def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
    self.name = name
    self.effects = effects
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self._def = _def
    self.description = description
    self.recipe = recipe

    def activate(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)


    class XyzMonster(object):
    def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
    self.name = name
    self.effects = effects
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self._def = _def
    self.description = description
    self.recipe = recipe
    self.materials = recipe

    def activate(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)


    class FusionMonster(object):
    def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
    self.name = name
    self.effects = effects
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self._def = _def
    self.description = description
    self.recipe = recipe

    def activate(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)


    class PendulumMonster(object):
    def __init__(self, name, effects, pendulum_effects, pendulum_scale, attributes, monster_type, atk, _def,
    description, recipe):
    self.name = name
    self.effects = effects
    self.pendulum_effects = pendulum_effects
    self.pendulum_scale = pendulum_scale
    self.attributes = attributes
    self.type = monster_type
    self.atk = atk
    self._def = _def
    self.description = description
    self.recipe = recipe
    self.materials = recipe

    def activate(self):
    """
    Activate the effect of this monster.
    """
    for effect in self.effects:
    eval(effect)

    def pendulum_activate(self):
    """
    Activate the effect of this monster while in Spell/Trap Zone.
    """
    for effect in self.pendulum_effects:
    eval(effect)









    share|improve this question











    $endgroup$














      4












      4








      4





      $begingroup$


      I made a project in Python 3.7.1 that includes classes to create Yu-Gi-Oh cards. This isn't the entire game; it is just the cards itself. I will create the entire game later. I want feedback on how to improve my code.



      class Deck(object):
      def __init__(self, main_deck):
      self.main_deck = main_deck

      def add_normal_cards(self, card_to_add, all_cards):
      """
      Add monsters, spells and traps to the deck.
      """
      if len(self.main_deck) > 60:
      return "You have to many cards in your deck (60)."
      else:
      card_counter = 0
      # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
      # will be added eventually.
      for card in self.main_deck:
      if card == card_to_add:
      card_counter += 1
      if card_counter == 3:
      return "You have to many copies of that card in your deck (3)."
      else:
      if card_to_add not in all_cards:
      return "That card hasn't been added to the game yet (" + card_to_add + ")."
      else:
      self.main_deck.append(card_to_add)

      def add_extra_cards(self, card_to_add, all_cards):
      """
      Add monsters, spells and traps to the deck.
      """
      if len(self.main_deck) > 15:
      return "You have to many cards in your extra deck (15)."
      else:
      card_counter = 0
      # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
      # will be added eventually.
      for card in self.main_deck:
      if card == card_to_add:
      card_counter += 1
      if card_counter == 3:
      return "You have to many copies of that card in your deck (3)."
      else:
      if card_to_add not in all_cards:
      return "That card hasn't been added to the game yet (" + card_to_add + ")."
      else:
      self.main_deck.append(card_to_add)


      class Monster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description

      def effect(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class Spell(object):
      def __init__(self, name, effects):
      self.name = name
      self.effects = effects

      def activate(self):
      """
      Activate the effect of this spell.
      """
      for effect in self.effects:
      eval(effect)


      class Trap(object):
      def __init__(self, name, effects):
      self.name = name
      self.effects = effects

      def activate(self):
      """
      Activate the effect of this spell.
      """
      for effect in self.effects:
      eval(effect)


      class LinkMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, link_rating, description, recipe, links):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self.link_rating = link_rating
      self.description = description
      self.recipe = recipe
      self.links = links

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class SynchroMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class XyzMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe
      self.materials = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class FusionMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class PendulumMonster(object):
      def __init__(self, name, effects, pendulum_effects, pendulum_scale, attributes, monster_type, atk, _def,
      description, recipe):
      self.name = name
      self.effects = effects
      self.pendulum_effects = pendulum_effects
      self.pendulum_scale = pendulum_scale
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe
      self.materials = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)

      def pendulum_activate(self):
      """
      Activate the effect of this monster while in Spell/Trap Zone.
      """
      for effect in self.pendulum_effects:
      eval(effect)









      share|improve this question











      $endgroup$




      I made a project in Python 3.7.1 that includes classes to create Yu-Gi-Oh cards. This isn't the entire game; it is just the cards itself. I will create the entire game later. I want feedback on how to improve my code.



      class Deck(object):
      def __init__(self, main_deck):
      self.main_deck = main_deck

      def add_normal_cards(self, card_to_add, all_cards):
      """
      Add monsters, spells and traps to the deck.
      """
      if len(self.main_deck) > 60:
      return "You have to many cards in your deck (60)."
      else:
      card_counter = 0
      # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
      # will be added eventually.
      for card in self.main_deck:
      if card == card_to_add:
      card_counter += 1
      if card_counter == 3:
      return "You have to many copies of that card in your deck (3)."
      else:
      if card_to_add not in all_cards:
      return "That card hasn't been added to the game yet (" + card_to_add + ")."
      else:
      self.main_deck.append(card_to_add)

      def add_extra_cards(self, card_to_add, all_cards):
      """
      Add monsters, spells and traps to the deck.
      """
      if len(self.main_deck) > 15:
      return "You have to many cards in your extra deck (15)."
      else:
      card_counter = 0
      # Check to see how many copies of a card there are in your deck. Maximum 3 of the same card. Limited cards
      # will be added eventually.
      for card in self.main_deck:
      if card == card_to_add:
      card_counter += 1
      if card_counter == 3:
      return "You have to many copies of that card in your deck (3)."
      else:
      if card_to_add not in all_cards:
      return "That card hasn't been added to the game yet (" + card_to_add + ")."
      else:
      self.main_deck.append(card_to_add)


      class Monster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description

      def effect(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class Spell(object):
      def __init__(self, name, effects):
      self.name = name
      self.effects = effects

      def activate(self):
      """
      Activate the effect of this spell.
      """
      for effect in self.effects:
      eval(effect)


      class Trap(object):
      def __init__(self, name, effects):
      self.name = name
      self.effects = effects

      def activate(self):
      """
      Activate the effect of this spell.
      """
      for effect in self.effects:
      eval(effect)


      class LinkMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, link_rating, description, recipe, links):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self.link_rating = link_rating
      self.description = description
      self.recipe = recipe
      self.links = links

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class SynchroMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class XyzMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe
      self.materials = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class FusionMonster(object):
      def __init__(self, name, effects, attributes, monster_type, atk, _def, description, recipe):
      self.name = name
      self.effects = effects
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)


      class PendulumMonster(object):
      def __init__(self, name, effects, pendulum_effects, pendulum_scale, attributes, monster_type, atk, _def,
      description, recipe):
      self.name = name
      self.effects = effects
      self.pendulum_effects = pendulum_effects
      self.pendulum_scale = pendulum_scale
      self.attributes = attributes
      self.type = monster_type
      self.atk = atk
      self._def = _def
      self.description = description
      self.recipe = recipe
      self.materials = recipe

      def activate(self):
      """
      Activate the effect of this monster.
      """
      for effect in self.effects:
      eval(effect)

      def pendulum_activate(self):
      """
      Activate the effect of this monster while in Spell/Trap Zone.
      """
      for effect in self.pendulum_effects:
      eval(effect)






      python python-3.x playing-cards






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 2 hours ago









      Jamal

      30.5k11121227




      30.5k11121227










      asked 2 hours ago









      Jerry CuiJerry Cui

      739




      739




















          2 Answers
          2






          active

          oldest

          votes


















          3












          $begingroup$

          • I know you're trying to abbreviate "defense," but you could consider writing the whole thing out instead of making inconsistent naming with the preceding underscore. As such, you could write out "attack" as well to keep it more consistent.

          • Perhaps all those monster classes should be consolidates somehow. There are a lot of repeated self statements and similar functions, making the code harder to follow and likely maintain.


          • The 60, 15, and 3 are "magic numbers" (numbers without some kind of given context), and from where they are, they could be harder to maintain.



            Although Python doesn't actual constants like other languages, you can still do something similar above the functions:



            MAX_DECK_CARDS = 60




            MAX_EXTRA_CARDS = 15




            MAX_EXTRA_CARDS = 3



          • There's a grammatical error here:




            "You have to many copies of that card in your deck (3)."



            It should be "too" instead of "to."




          • When incrementing by 1:




            card_counter += 1



            You can just use the ++ operator:



            card_counter++






          share|improve this answer









          $endgroup$








          • 1




            $begingroup$
            Yes to everything except ++. That isn't a thing in Python. Please remove it.
            $endgroup$
            – Reinderien
            26 mins ago


















          3












          $begingroup$

          Trim redundant else



          ...here:



          if len(self.main_deck) > 60:
          return "You have to many cards in your deck (60)."
          else:


          The else isn't needed because you've already returned. This pattern happens in a few places.



          Lose some loops



          This:



           card_counter = 0
          for card in self.main_deck:
          if card == card_to_add:
          card_counter += 1


          can be



          card_counter = sum(1 for card in self.main_deck if card == card_to_add)


          However, that exposes a larger issue - you shouldn't be keeping copies of the same card value in your deck data structure. Instead, consider something like a dictionary, whose keys are the card names, and the values are card counts. That would really simplify much of your code.



          Don't eval



          Just don't. There's never a good reason. Make effects an iterable of functions, and simply call them.






          share|improve this answer









          $endgroup$













            Your Answer





            StackExchange.ifUsing("editor", function ()
            return StackExchange.using("mathjaxEditing", function ()
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            );
            );
            , "mathjax-editing");

            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216560%2fyu-gi-oh-cards-in-python-3%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            3












            $begingroup$

            • I know you're trying to abbreviate "defense," but you could consider writing the whole thing out instead of making inconsistent naming with the preceding underscore. As such, you could write out "attack" as well to keep it more consistent.

            • Perhaps all those monster classes should be consolidates somehow. There are a lot of repeated self statements and similar functions, making the code harder to follow and likely maintain.


            • The 60, 15, and 3 are "magic numbers" (numbers without some kind of given context), and from where they are, they could be harder to maintain.



              Although Python doesn't actual constants like other languages, you can still do something similar above the functions:



              MAX_DECK_CARDS = 60




              MAX_EXTRA_CARDS = 15




              MAX_EXTRA_CARDS = 3



            • There's a grammatical error here:




              "You have to many copies of that card in your deck (3)."



              It should be "too" instead of "to."




            • When incrementing by 1:




              card_counter += 1



              You can just use the ++ operator:



              card_counter++






            share|improve this answer









            $endgroup$








            • 1




              $begingroup$
              Yes to everything except ++. That isn't a thing in Python. Please remove it.
              $endgroup$
              – Reinderien
              26 mins ago















            3












            $begingroup$

            • I know you're trying to abbreviate "defense," but you could consider writing the whole thing out instead of making inconsistent naming with the preceding underscore. As such, you could write out "attack" as well to keep it more consistent.

            • Perhaps all those monster classes should be consolidates somehow. There are a lot of repeated self statements and similar functions, making the code harder to follow and likely maintain.


            • The 60, 15, and 3 are "magic numbers" (numbers without some kind of given context), and from where they are, they could be harder to maintain.



              Although Python doesn't actual constants like other languages, you can still do something similar above the functions:



              MAX_DECK_CARDS = 60




              MAX_EXTRA_CARDS = 15




              MAX_EXTRA_CARDS = 3



            • There's a grammatical error here:




              "You have to many copies of that card in your deck (3)."



              It should be "too" instead of "to."




            • When incrementing by 1:




              card_counter += 1



              You can just use the ++ operator:



              card_counter++






            share|improve this answer









            $endgroup$








            • 1




              $begingroup$
              Yes to everything except ++. That isn't a thing in Python. Please remove it.
              $endgroup$
              – Reinderien
              26 mins ago













            3












            3








            3





            $begingroup$

            • I know you're trying to abbreviate "defense," but you could consider writing the whole thing out instead of making inconsistent naming with the preceding underscore. As such, you could write out "attack" as well to keep it more consistent.

            • Perhaps all those monster classes should be consolidates somehow. There are a lot of repeated self statements and similar functions, making the code harder to follow and likely maintain.


            • The 60, 15, and 3 are "magic numbers" (numbers without some kind of given context), and from where they are, they could be harder to maintain.



              Although Python doesn't actual constants like other languages, you can still do something similar above the functions:



              MAX_DECK_CARDS = 60




              MAX_EXTRA_CARDS = 15




              MAX_EXTRA_CARDS = 3



            • There's a grammatical error here:




              "You have to many copies of that card in your deck (3)."



              It should be "too" instead of "to."




            • When incrementing by 1:




              card_counter += 1



              You can just use the ++ operator:



              card_counter++






            share|improve this answer









            $endgroup$



            • I know you're trying to abbreviate "defense," but you could consider writing the whole thing out instead of making inconsistent naming with the preceding underscore. As such, you could write out "attack" as well to keep it more consistent.

            • Perhaps all those monster classes should be consolidates somehow. There are a lot of repeated self statements and similar functions, making the code harder to follow and likely maintain.


            • The 60, 15, and 3 are "magic numbers" (numbers without some kind of given context), and from where they are, they could be harder to maintain.



              Although Python doesn't actual constants like other languages, you can still do something similar above the functions:



              MAX_DECK_CARDS = 60




              MAX_EXTRA_CARDS = 15




              MAX_EXTRA_CARDS = 3



            • There's a grammatical error here:




              "You have to many copies of that card in your deck (3)."



              It should be "too" instead of "to."




            • When incrementing by 1:




              card_counter += 1



              You can just use the ++ operator:



              card_counter++







            share|improve this answer












            share|improve this answer



            share|improve this answer










            answered 1 hour ago









            JamalJamal

            30.5k11121227




            30.5k11121227







            • 1




              $begingroup$
              Yes to everything except ++. That isn't a thing in Python. Please remove it.
              $endgroup$
              – Reinderien
              26 mins ago












            • 1




              $begingroup$
              Yes to everything except ++. That isn't a thing in Python. Please remove it.
              $endgroup$
              – Reinderien
              26 mins ago







            1




            1




            $begingroup$
            Yes to everything except ++. That isn't a thing in Python. Please remove it.
            $endgroup$
            – Reinderien
            26 mins ago




            $begingroup$
            Yes to everything except ++. That isn't a thing in Python. Please remove it.
            $endgroup$
            – Reinderien
            26 mins ago













            3












            $begingroup$

            Trim redundant else



            ...here:



            if len(self.main_deck) > 60:
            return "You have to many cards in your deck (60)."
            else:


            The else isn't needed because you've already returned. This pattern happens in a few places.



            Lose some loops



            This:



             card_counter = 0
            for card in self.main_deck:
            if card == card_to_add:
            card_counter += 1


            can be



            card_counter = sum(1 for card in self.main_deck if card == card_to_add)


            However, that exposes a larger issue - you shouldn't be keeping copies of the same card value in your deck data structure. Instead, consider something like a dictionary, whose keys are the card names, and the values are card counts. That would really simplify much of your code.



            Don't eval



            Just don't. There's never a good reason. Make effects an iterable of functions, and simply call them.






            share|improve this answer









            $endgroup$

















              3












              $begingroup$

              Trim redundant else



              ...here:



              if len(self.main_deck) > 60:
              return "You have to many cards in your deck (60)."
              else:


              The else isn't needed because you've already returned. This pattern happens in a few places.



              Lose some loops



              This:



               card_counter = 0
              for card in self.main_deck:
              if card == card_to_add:
              card_counter += 1


              can be



              card_counter = sum(1 for card in self.main_deck if card == card_to_add)


              However, that exposes a larger issue - you shouldn't be keeping copies of the same card value in your deck data structure. Instead, consider something like a dictionary, whose keys are the card names, and the values are card counts. That would really simplify much of your code.



              Don't eval



              Just don't. There's never a good reason. Make effects an iterable of functions, and simply call them.






              share|improve this answer









              $endgroup$















                3












                3








                3





                $begingroup$

                Trim redundant else



                ...here:



                if len(self.main_deck) > 60:
                return "You have to many cards in your deck (60)."
                else:


                The else isn't needed because you've already returned. This pattern happens in a few places.



                Lose some loops



                This:



                 card_counter = 0
                for card in self.main_deck:
                if card == card_to_add:
                card_counter += 1


                can be



                card_counter = sum(1 for card in self.main_deck if card == card_to_add)


                However, that exposes a larger issue - you shouldn't be keeping copies of the same card value in your deck data structure. Instead, consider something like a dictionary, whose keys are the card names, and the values are card counts. That would really simplify much of your code.



                Don't eval



                Just don't. There's never a good reason. Make effects an iterable of functions, and simply call them.






                share|improve this answer









                $endgroup$



                Trim redundant else



                ...here:



                if len(self.main_deck) > 60:
                return "You have to many cards in your deck (60)."
                else:


                The else isn't needed because you've already returned. This pattern happens in a few places.



                Lose some loops



                This:



                 card_counter = 0
                for card in self.main_deck:
                if card == card_to_add:
                card_counter += 1


                can be



                card_counter = sum(1 for card in self.main_deck if card == card_to_add)


                However, that exposes a larger issue - you shouldn't be keeping copies of the same card value in your deck data structure. Instead, consider something like a dictionary, whose keys are the card names, and the values are card counts. That would really simplify much of your code.



                Don't eval



                Just don't. There's never a good reason. Make effects an iterable of functions, and simply call them.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 20 mins ago









                ReinderienReinderien

                5,035925




                5,035925



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216560%2fyu-gi-oh-cards-in-python-3%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Францішак Багушэвіч Змест Сям'я | Біяграфія | Творчасць | Мова Багушэвіча | Ацэнкі дзейнасці | Цікавыя факты | Спадчына | Выбраная бібліяграфія | Ушанаванне памяці | У філатэліі | Зноскі | Літаратура | Спасылкі | НавігацыяЛяхоўскі У. Рупіўся дзеля Бога і людзей: Жыццёвы шлях Лявона Вітан-Дубейкаўскага // Вольскі і Памідораў з песняй пра немца Адвакат, паэт, народны заступнік Ашмянскі веснікВ Минске появится площадь Богушевича и улица Сырокомли, Белорусская деловая газета, 19 июля 2001 г.Айцец беларускай нацыянальнай ідэі паўстаў у бронзе Сяргей Аляксандравіч Адашкевіч (1918, Мінск). 80-я гады. Бюст «Францішак Багушэвіч».Яўген Мікалаевіч Ціхановіч. «Партрэт Францішка Багушэвіча»Мікола Мікалаевіч Купава. «Партрэт зачынальніка новай беларускай літаратуры Францішка Багушэвіча»Уладзімір Іванавіч Мелехаў. На помніку «Змагарам за родную мову» Барэльеф «Францішак Багушэвіч»Памяць пра Багушэвіча на Віленшчыне Страчаная сталіца. Беларускія шыльды на вуліцах Вільні«Krynica». Ideologia i przywódcy białoruskiego katolicyzmuФранцішак БагушэвічТворы на knihi.comТворы Францішка Багушэвіча на bellib.byСодаль Уладзімір. Францішак Багушэвіч на Лідчыне;Луцкевіч Антон. Жыцьцё і творчасьць Фр. Багушэвіча ў успамінах ягоных сучасьнікаў // Запісы Беларускага Навуковага таварыства. Вільня, 1938. Сшытак 1. С. 16-34.Большая российская1188761710000 0000 5537 633Xn9209310021619551927869394п

                    Беларусь Змест Назва Гісторыя Геаграфія Сімволіка Дзяржаўны лад Палітычныя партыі Міжнароднае становішча і знешняя палітыка Адміністрацыйны падзел Насельніцтва Эканоміка Культура і грамадства Сацыяльная сфера Узброеныя сілы Заўвагі Літаратура Спасылкі НавігацыяHGЯOiТоп-2011 г. (па версіі ej.by)Топ-2013 г. (па версіі ej.by)Топ-2016 г. (па версіі ej.by)Топ-2017 г. (па версіі ej.by)Нацыянальны статыстычны камітэт Рэспублікі БеларусьШчыльнасць насельніцтва па краінахhttp://naviny.by/rubrics/society/2011/09/16/ic_articles_116_175144/А. Калечыц, У. Ксяндзоў. Спробы засялення краю неандэртальскім чалавекам.І ў Менску былі мамантыА. Калечыц, У. Ксяндзоў. Старажытны каменны век (палеаліт). Першапачатковае засяленне тэрыторыіГ. Штыхаў. Балты і славяне ў VI—VIII стст.М. Клімаў. Полацкае княства ў IX—XI стст.Г. Штыхаў, В. Ляўко. Палітычная гісторыя Полацкай зямліГ. Штыхаў. Дзяржаўны лад у землях-княствахГ. Штыхаў. Дзяржаўны лад у землях-княствахБеларускія землі ў складзе Вялікага Княства ЛітоўскагаЛюблінская унія 1569 г."The Early Stages of Independence"Zapomniane prawdy25 гадоў таму было аб'яўлена, што Язэп Пілсудскі — беларус (фота)Наша вадаДакументы ЧАЭС: Забруджванне тэрыторыі Беларусі « ЧАЭС Зона адчужэнняСведения о политических партиях, зарегистрированных в Республике Беларусь // Министерство юстиции Республики БеларусьСтатыстычны бюлетэнь „Полаўзроставая структура насельніцтва Рэспублікі Беларусь на 1 студзеня 2012 года і сярэднегадовая колькасць насельніцтва за 2011 год“Индекс человеческого развития Беларуси — не было бы нижеБеларусь занимает первое место в СНГ по индексу развития с учетом гендерного факцёраНацыянальны статыстычны камітэт Рэспублікі БеларусьКанстытуцыя РБ. Артыкул 17Трансфармацыйныя задачы БеларусіВыйсце з крызісу — далейшае рэфармаванне Беларускі рубель — сусветны лідар па дэвальвацыяхПра змену коштаў у кастрычніку 2011 г.Бядней за беларусаў у СНД толькі таджыкіСярэдні заробак у верасні дасягнуў 2,26 мільёна рублёўЭканомікаГаласуем за ТОП-100 беларускай прозыСучасныя беларускія мастакіАрхитектура Беларуси BELARUS.BYА. Каханоўскі. Культура Беларусі ўсярэдзіне XVII—XVIII ст.Анталогія беларускай народнай песні, гуказапісы спеваўБеларускія Музычныя IнструментыБеларускі рок, які мы страцілі. Топ-10 гуртоў«Мясцовы час» — нязгаслая легенда беларускай рок-музыкіСЯРГЕЙ БУДКІН. МЫ НЯ ЗНАЕМ СВАЁЙ МУЗЫКІМ. А. Каладзінскі. НАРОДНЫ ТЭАТРМагнацкія культурныя цэнтрыПублічная дыскусія «Беларуская новая пьеса: без беларускай мовы ці беларуская?»Беларускія драматургі па-ранейшаму лепш ставяцца за мяжой, чым на радзіме«Працэс незалежнага кіно пайшоў, і дзяржаву турбуе яго непадкантрольнасць»Беларускія філосафы ў пошуках прасторыВсе идём в библиотекуАрхіваванаАб Нацыянальнай праграме даследавання і выкарыстання касмічнай прасторы ў мірных мэтах на 2008—2012 гадыУ космас — разам.У суседнім з Барысаўскім раёне пабудуюць Камандна-вымяральны пунктСвяты і абрады беларусаў«Мірныя бульбашы з малой краіны» — 5 непраўдзівых стэрэатыпаў пра БеларусьМ. Раманюк. Беларускае народнае адзеннеУ Беларусі скарачаецца колькасць злачынстваўЛукашэнка незадаволены мінскімі ўладамі Крадзяжы складаюць у Мінску каля 70% злачынстваў Узровень злачыннасці ў Мінскай вобласці — адзін з самых высокіх у краіне Генпракуратура аналізуе стан са злачыннасцю ў Беларусі па каэфіцыенце злачыннасці У Беларусі стабілізавалася крымінагеннае становішча, лічыць генпракурорЗамежнікі сталі здзяйсняць у Беларусі больш злачынстваўМУС Беларусі турбуе рост рэцыдыўнай злачыннасціЯ з ЖЭСа. Дазволіце вас абкрасці! Рэйтынг усіх службаў і падраздзяленняў ГУУС Мінгарвыканкама вырасАб КДБ РБГісторыя Аператыўна-аналітычнага цэнтра РБГісторыя ДКФРТаможняagentura.ruБеларусьBelarus.by — Афіцыйны сайт Рэспублікі БеларусьСайт урада БеларусіRadzima.org — Збор архітэктурных помнікаў, гісторыя Беларусі«Глобус Беларуси»Гербы и флаги БеларусиАсаблівасці каменнага веку на БеларусіА. Калечыц, У. Ксяндзоў. Старажытны каменны век (палеаліт). Першапачатковае засяленне тэрыторыіУ. Ксяндзоў. Сярэдні каменны век (мезаліт). Засяленне краю плямёнамі паляўнічых, рыбакоў і збіральнікаўА. Калечыц, М. Чарняўскі. Плямёны на тэрыторыі Беларусі ў новым каменным веку (неаліце)А. Калечыц, У. Ксяндзоў, М. Чарняўскі. Гаспадарчыя заняткі ў каменным векуЭ. Зайкоўскі. Духоўная культура ў каменным векуАсаблівасці бронзавага веку на БеларусіФарміраванне супольнасцей ранняга перыяду бронзавага векуФотографии БеларусиРоля беларускіх зямель ва ўтварэнні і ўмацаванні ВКЛВ. Фадзеева. З гісторыі развіцця беларускай народнай вышыўкіDMOZGran catalanaБольшая российскаяBritannica (анлайн)Швейцарскі гістарычны15325917611952699xDA123282154079143-90000 0001 2171 2080n9112870100577502ge128882171858027501086026362074122714179пппппп

                    ValueError: Expected n_neighbors <= n_samples, but n_samples = 1, n_neighbors = 6 (SMOTE) The 2019 Stack Overflow Developer Survey Results Are InCan SMOTE be applied over sequence of words (sentences)?ValueError when doing validation with random forestsSMOTE and multi class oversamplingLogic behind SMOTE-NC?ValueError: Error when checking target: expected dense_1 to have shape (7,) but got array with shape (1,)SmoteBoost: Should SMOTE be ran individually for each iteration/tree in the boosting?solving multi-class imbalance classification using smote and OSSUsing SMOTE for Synthetic Data generation to improve performance on unbalanced dataproblem of entry format for a simple model in KerasSVM SMOTE fit_resample() function runs forever with no result