PyTorch does not seem to be optimizing correctly2019 Community Moderator ElectionPyTorch vs. Tensorflow FoldHow to install pytorch in windows?Forward and backward process in pyTorchPytorch CapabilitiesFastAI to PyTorch conversionWhat is the use of torch.no_grad in pytorch?Inseting pretrained network to pytorchHow to re-initialise batch sampling with pytorch dataloader?Replicating RNN within PyTorchPytorch dynamic forward pass

The baby cries all morning

Can somebody explain Brexit in a few child-proof sentences?

Tiptoe or tiphoof? Adjusting words to better fit fantasy races

Do I need a multiple entry visa for a trip UK -> Sweden -> UK?

voltage of sounds of mp3files

Is there a good way to store credentials outside of a password manager?

Your magic is very sketchy

Lay out the Carpet

How can a jailer prevent the Forge Cleric's Artisan's Blessing from being used?

How do I rename a LINUX host without needing to reboot for the rename to take effect?

Time travel short story where a man arrives in the late 19th century in a time machine and then sends the machine back into the past

The plural of 'stomach"

Why Were Madagascar and New Zealand Discovered So Late?

What is the term when two people sing in harmony, but they aren't singing the same notes?

How can I replace every global instance of "x[2]" with "x_2"

At which point does a character regain all their Hit Dice?

Mapping a list into a phase plot

Finding all intervals that match predicate in vector

Is there any reason not to eat food that's been dropped on the surface of the moon?

Bash method for viewing beginning and end of file

Can criminal fraud exist without damages?

Cynical novel that describes an America ruled by the media, arms manufacturers, and ethnic figureheads

Have I saved too much for retirement so far?

If you attempt to grapple an opponent that you are hidden from, do they roll at disadvantage?



PyTorch does not seem to be optimizing correctly



2019 Community Moderator ElectionPyTorch vs. Tensorflow FoldHow to install pytorch in windows?Forward and backward process in pyTorchPytorch CapabilitiesFastAI to PyTorch conversionWhat is the use of torch.no_grad in pytorch?Inseting pretrained network to pytorchHow to re-initialise batch sampling with pytorch dataloader?Replicating RNN within PyTorchPytorch dynamic forward pass










0












$begingroup$


I am trying to minimize the following function:



$$f(theta_1, dots, theta_n) = frac1ssum_j =1^sleft(sum_i=1^n sin(t_j + theta_i)right)^2$$



with respect to $(theta_1, dots, theta_n)$. Here $t_j$ are regularly spaced points in the interval $[0, 2pi)$.



So here is the Python (PyTorch) code for that. The optimization does not seem to be computed correctly (the gradients seem to only advance along the line $theta_1 = cdots = theta_n$, which of of course incorrect).



import numpy as np
import torch

def phaseOptimize(n, s = 48000, nsteps = 1000):
learning_rate = 1e-3

theta = torch.zeros([n, 1], requires_grad=True)
l = torch.linspace(0, 2 * np.pi, s)
t = torch.stack([l] * n)
T = t + theta

for jj in range(nsteps):
loss = T.sin().sum(0).pow(2).sum() / s
loss.backward()
theta.data -= learning_rate * theta.grad.data

print('Optimal theta: nn', theta.data)
print('nnMaximum value:', T.sin().sum(0).abs().max().item())


Below is a sample output.



phaseOptimize(5, nsteps=100)


Optimal theta:

tensor([[1.2812e-07],
[1.2812e-07],
[1.2812e-07],
[1.2812e-07],
[1.2812e-07]], requires_grad=True)


Maximum value: 5.0


I am assuming this has something to do with broadcasting in



T = t + theta


and/or the way I am computing the loss function.



One way to verify that optimization is incorrect, is to simply evaluate the loss function at random values for the array $theta_1, dots, theta_n$, say uniformly distributed in $[0, 2pi]$. The maximum value in this case is almost always much lower than the maximum value reported by phaseOptimize(). Much easier in fact is to consider the case with $n = 2$, and simply evaluate at $theta_1 = 0$ and $theta_2 = pi$. In that case we get:



phaseOptimize(2, nsteps=100)

Optimal theta:

tensor([[2.8599e-08],
[2.8599e-08]])


Maximum value: 2.0


On the other hand,



theta = torch.FloatTensor([[0], [np.pi]])
l = torch.linspace(0, 2 * np.pi, 48000)
t = torch.stack([l] * 2)
T = t + theta

T.sin().sum(0).abs().max().item()


produces



3.2782554626464844e-07








share









New contributor




wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I am trying to minimize the following function:



    $$f(theta_1, dots, theta_n) = frac1ssum_j =1^sleft(sum_i=1^n sin(t_j + theta_i)right)^2$$



    with respect to $(theta_1, dots, theta_n)$. Here $t_j$ are regularly spaced points in the interval $[0, 2pi)$.



    So here is the Python (PyTorch) code for that. The optimization does not seem to be computed correctly (the gradients seem to only advance along the line $theta_1 = cdots = theta_n$, which of of course incorrect).



    import numpy as np
    import torch

    def phaseOptimize(n, s = 48000, nsteps = 1000):
    learning_rate = 1e-3

    theta = torch.zeros([n, 1], requires_grad=True)
    l = torch.linspace(0, 2 * np.pi, s)
    t = torch.stack([l] * n)
    T = t + theta

    for jj in range(nsteps):
    loss = T.sin().sum(0).pow(2).sum() / s
    loss.backward()
    theta.data -= learning_rate * theta.grad.data

    print('Optimal theta: nn', theta.data)
    print('nnMaximum value:', T.sin().sum(0).abs().max().item())


    Below is a sample output.



    phaseOptimize(5, nsteps=100)


    Optimal theta:

    tensor([[1.2812e-07],
    [1.2812e-07],
    [1.2812e-07],
    [1.2812e-07],
    [1.2812e-07]], requires_grad=True)


    Maximum value: 5.0


    I am assuming this has something to do with broadcasting in



    T = t + theta


    and/or the way I am computing the loss function.



    One way to verify that optimization is incorrect, is to simply evaluate the loss function at random values for the array $theta_1, dots, theta_n$, say uniformly distributed in $[0, 2pi]$. The maximum value in this case is almost always much lower than the maximum value reported by phaseOptimize(). Much easier in fact is to consider the case with $n = 2$, and simply evaluate at $theta_1 = 0$ and $theta_2 = pi$. In that case we get:



    phaseOptimize(2, nsteps=100)

    Optimal theta:

    tensor([[2.8599e-08],
    [2.8599e-08]])


    Maximum value: 2.0


    On the other hand,



    theta = torch.FloatTensor([[0], [np.pi]])
    l = torch.linspace(0, 2 * np.pi, 48000)
    t = torch.stack([l] * 2)
    T = t + theta

    T.sin().sum(0).abs().max().item()


    produces



    3.2782554626464844e-07








    share









    New contributor




    wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I am trying to minimize the following function:



      $$f(theta_1, dots, theta_n) = frac1ssum_j =1^sleft(sum_i=1^n sin(t_j + theta_i)right)^2$$



      with respect to $(theta_1, dots, theta_n)$. Here $t_j$ are regularly spaced points in the interval $[0, 2pi)$.



      So here is the Python (PyTorch) code for that. The optimization does not seem to be computed correctly (the gradients seem to only advance along the line $theta_1 = cdots = theta_n$, which of of course incorrect).



      import numpy as np
      import torch

      def phaseOptimize(n, s = 48000, nsteps = 1000):
      learning_rate = 1e-3

      theta = torch.zeros([n, 1], requires_grad=True)
      l = torch.linspace(0, 2 * np.pi, s)
      t = torch.stack([l] * n)
      T = t + theta

      for jj in range(nsteps):
      loss = T.sin().sum(0).pow(2).sum() / s
      loss.backward()
      theta.data -= learning_rate * theta.grad.data

      print('Optimal theta: nn', theta.data)
      print('nnMaximum value:', T.sin().sum(0).abs().max().item())


      Below is a sample output.



      phaseOptimize(5, nsteps=100)


      Optimal theta:

      tensor([[1.2812e-07],
      [1.2812e-07],
      [1.2812e-07],
      [1.2812e-07],
      [1.2812e-07]], requires_grad=True)


      Maximum value: 5.0


      I am assuming this has something to do with broadcasting in



      T = t + theta


      and/or the way I am computing the loss function.



      One way to verify that optimization is incorrect, is to simply evaluate the loss function at random values for the array $theta_1, dots, theta_n$, say uniformly distributed in $[0, 2pi]$. The maximum value in this case is almost always much lower than the maximum value reported by phaseOptimize(). Much easier in fact is to consider the case with $n = 2$, and simply evaluate at $theta_1 = 0$ and $theta_2 = pi$. In that case we get:



      phaseOptimize(2, nsteps=100)

      Optimal theta:

      tensor([[2.8599e-08],
      [2.8599e-08]])


      Maximum value: 2.0


      On the other hand,



      theta = torch.FloatTensor([[0], [np.pi]])
      l = torch.linspace(0, 2 * np.pi, 48000)
      t = torch.stack([l] * 2)
      T = t + theta

      T.sin().sum(0).abs().max().item()


      produces



      3.2782554626464844e-07








      share









      New contributor




      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am trying to minimize the following function:



      $$f(theta_1, dots, theta_n) = frac1ssum_j =1^sleft(sum_i=1^n sin(t_j + theta_i)right)^2$$



      with respect to $(theta_1, dots, theta_n)$. Here $t_j$ are regularly spaced points in the interval $[0, 2pi)$.



      So here is the Python (PyTorch) code for that. The optimization does not seem to be computed correctly (the gradients seem to only advance along the line $theta_1 = cdots = theta_n$, which of of course incorrect).



      import numpy as np
      import torch

      def phaseOptimize(n, s = 48000, nsteps = 1000):
      learning_rate = 1e-3

      theta = torch.zeros([n, 1], requires_grad=True)
      l = torch.linspace(0, 2 * np.pi, s)
      t = torch.stack([l] * n)
      T = t + theta

      for jj in range(nsteps):
      loss = T.sin().sum(0).pow(2).sum() / s
      loss.backward()
      theta.data -= learning_rate * theta.grad.data

      print('Optimal theta: nn', theta.data)
      print('nnMaximum value:', T.sin().sum(0).abs().max().item())


      Below is a sample output.



      phaseOptimize(5, nsteps=100)


      Optimal theta:

      tensor([[1.2812e-07],
      [1.2812e-07],
      [1.2812e-07],
      [1.2812e-07],
      [1.2812e-07]], requires_grad=True)


      Maximum value: 5.0


      I am assuming this has something to do with broadcasting in



      T = t + theta


      and/or the way I am computing the loss function.



      One way to verify that optimization is incorrect, is to simply evaluate the loss function at random values for the array $theta_1, dots, theta_n$, say uniformly distributed in $[0, 2pi]$. The maximum value in this case is almost always much lower than the maximum value reported by phaseOptimize(). Much easier in fact is to consider the case with $n = 2$, and simply evaluate at $theta_1 = 0$ and $theta_2 = pi$. In that case we get:



      phaseOptimize(2, nsteps=100)

      Optimal theta:

      tensor([[2.8599e-08],
      [2.8599e-08]])


      Maximum value: 2.0


      On the other hand,



      theta = torch.FloatTensor([[0], [np.pi]])
      l = torch.linspace(0, 2 * np.pi, 48000)
      t = torch.stack([l] * 2)
      T = t + theta

      T.sin().sum(0).abs().max().item()


      produces



      3.2782554626464844e-07






      pytorch





      share









      New contributor




      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share









      New contributor




      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share








      edited 2 mins ago







      wny













      New contributor




      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 7 mins ago









      wnywny

      101




      101




      New contributor




      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      wny is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["$", "$"], ["\\(","\\)"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "557"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          wny is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fdatascience.stackexchange.com%2fquestions%2f48062%2fpytorch-does-not-seem-to-be-optimizing-correctly%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          wny is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          wny is a new contributor. Be nice, and check out our Code of Conduct.












          wny is a new contributor. Be nice, and check out our Code of Conduct.











          wny is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Data Science Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fdatascience.stackexchange.com%2fquestions%2f48062%2fpytorch-does-not-seem-to-be-optimizing-correctly%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Францішак Багушэвіч Змест Сям'я | Біяграфія | Творчасць | Мова Багушэвіча | Ацэнкі дзейнасці | Цікавыя факты | Спадчына | Выбраная бібліяграфія | Ушанаванне памяці | У філатэліі | Зноскі | Літаратура | Спасылкі | НавігацыяЛяхоўскі У. Рупіўся дзеля Бога і людзей: Жыццёвы шлях Лявона Вітан-Дубейкаўскага // Вольскі і Памідораў з песняй пра немца Адвакат, паэт, народны заступнік Ашмянскі веснікВ Минске появится площадь Богушевича и улица Сырокомли, Белорусская деловая газета, 19 июля 2001 г.Айцец беларускай нацыянальнай ідэі паўстаў у бронзе Сяргей Аляксандравіч Адашкевіч (1918, Мінск). 80-я гады. Бюст «Францішак Багушэвіч».Яўген Мікалаевіч Ціхановіч. «Партрэт Францішка Багушэвіча»Мікола Мікалаевіч Купава. «Партрэт зачынальніка новай беларускай літаратуры Францішка Багушэвіча»Уладзімір Іванавіч Мелехаў. На помніку «Змагарам за родную мову» Барэльеф «Францішак Багушэвіч»Памяць пра Багушэвіча на Віленшчыне Страчаная сталіца. Беларускія шыльды на вуліцах Вільні«Krynica». Ideologia i przywódcy białoruskiego katolicyzmuФранцішак БагушэвічТворы на knihi.comТворы Францішка Багушэвіча на bellib.byСодаль Уладзімір. Францішак Багушэвіч на Лідчыне;Луцкевіч Антон. Жыцьцё і творчасьць Фр. Багушэвіча ў успамінах ягоных сучасьнікаў // Запісы Беларускага Навуковага таварыства. Вільня, 1938. Сшытак 1. С. 16-34.Большая российская1188761710000 0000 5537 633Xn9209310021619551927869394п

          Partai Komunis Tiongkok Daftar isi Kepemimpinan | Pranala luar | Referensi | Menu navigasidiperiksa1 perubahan tertundacpc.people.com.cnSitus resmiSurat kabar resmi"Why the Communist Party is alive, well and flourishing in China"0307-1235"Full text of Constitution of Communist Party of China"smengembangkannyas

          ValueError: Expected n_neighbors <= n_samples, but n_samples = 1, n_neighbors = 6 (SMOTE) The 2019 Stack Overflow Developer Survey Results Are InCan SMOTE be applied over sequence of words (sentences)?ValueError when doing validation with random forestsSMOTE and multi class oversamplingLogic behind SMOTE-NC?ValueError: Error when checking target: expected dense_1 to have shape (7,) but got array with shape (1,)SmoteBoost: Should SMOTE be ran individually for each iteration/tree in the boosting?solving multi-class imbalance classification using smote and OSSUsing SMOTE for Synthetic Data generation to improve performance on unbalanced dataproblem of entry format for a simple model in KerasSVM SMOTE fit_resample() function runs forever with no result